Skip to content

(ADFA-2539) Fix EIO crash during ZipFile finalization #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Daniel-ADFA merged 3 commits into from
Jan 27, 2026
Merged

(ADFA-2539) Fix EIO crash during ZipFile finalization #852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
65da93f
(ADFA-2539) Fix EIO crash during ZipFile finalization Prevent Unchec…
Daniel-ADFA Jan 18, 2026
3cfdcd1
Remove JAR cache clearing on analysis cancellation
Daniel-ADFA Jan 19, 2026
2b6600c
Merge branch 'stage' into ADFA-2539
Daniel-ADFA Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...ds/build-deps/java-compiler/src/main/java/com/itsaky/androidide/zipfs2/ZipFileSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,7 +1076,10 @@ final String getString(byte[] name) {

@SuppressWarnings("deprecation")
protected void finalize() throws IOException {
close();
try {
close();
} catch (IOException ignored) {
}
}

// Reads len bytes of data from the specified offset into buf.
Expand Down
14 changes: 11 additions & 3 deletions ...vac-services/src/main/java/com/itsaky/androidide/javac/services/fs/CachedJarFileSystem.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import com.itsaky.androidide.zipfs2.ZipFileSystem
import com.itsaky.androidide.zipfs2.ZipFileSystemProvider
import jdkx.lang.model.SourceVersion
import openjdk.tools.javac.file.RelativePath.RelativeDirectory
import org.slf4j.LoggerFactory
import java.io.IOException
import java.nio.file.Path

Expand All @@ -34,17 +35,24 @@ class CachedJarFileSystem(
zfpath: Path?,
env: MutableMap<String, *>?
) : ZipFileSystem(provider, zfpath, env) {


companion object {
private val log = LoggerFactory.getLogger(CachedJarFileSystem::class.java)
}

internal val packages = mutableMapOf<RelativeDirectory, Path>()

override fun close() {
// Do nothing
// This is called manually by the Java LSP
}

@Throws(IOException::class)
fun doClose() {
super.close()
try {
super.close()
} catch (e: IOException) {
log.warn("IOException during CachedJarFileSystem close", e)
}
}

fun storeJARPackageDir(dir: Path?): Boolean {
Expand Down