Remove @_implementationOnly annotations#225
Merged
Merged
Conversation
Signed-off-by: Marcos Griselli <marcosg@lyft.com>
@_implementationOnly annotations
Contributor
Author
|
@natecook1000 sorry for the ping, can we add a reviewer for this? |
Contributor
|
@swift-ci Please test |
Member
|
Looks great, thanks @marcosgriselli! |
tshortli
reviewed
Apr 17, 2024
| #if swift(>=5.11) | ||
| internal import RealModule | ||
| #elseif swift(>=5.10) | ||
| import RealModule |
There was a problem hiding this comment.
Importing RealModule without @_implementationOnly in Swift 5.10, but with @_implementationOnly in Swift 5.9 doesn't make sense to me. With @_implementationOnly the dependency is hidden from dependents entirely. Without it, the dependency is exposed to dependents. If in practice it is ok to expose the RealModule dependency to dependents (as it seems it must be) then it would be more consistent to simply remove @_implementationOnly for <= 5.10, rather than having different semantics for 5.10 and <= 5.9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These annotations produce warnings when compiling without library evolution using Swift ≥5.10.
Replace them by private import when compiling using Swift ≥5.11.
Mirrors swiftlang/swift-syntax#2429
Checklist