Add support for joined short options#240
Merged
Merged
Conversation
mpapple-swift
approved these changes
Sep 28, 2020
mpapple-swift
left a comment
There was a problem hiding this comment.
Reviewed code; tested on Darwin. Looks good. Thanks for adding this enhancement @natecook1000.
murilxaraujo
approved these changes
Oct 21, 2020
This supports joined arguments, like '-Ddebug' or '-v4'. Joined arguments
need to be explicitly declared as `.customShort("D", allowingJoined: true)`.
1234c33 to
afe4f69
Compare
Member
Author
|
@swift-ci Please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This supports joined arguments, like '-Ddebug' or '-v4'. Joined arguments need to be explicitly declared as
.customShort("D", allowingJoined: true).Detailed Design
You can now specify a Boolean
allowingJoinedvalue when declaring a custom short name specification, like this:Existing calls still work as expected:
And now you can use joined syntax:
Documentation Plan
Expanded the documentation for
.customShort(_:allowingJoined:)on bothNameSpecificationandNameSpecification.Element.Test Plan
Unit tests covering the breadth of usage.
Source Impact
This is an additive change only, users must opt into the new functionality.
Checklist