Fix executable path when calling custom completion in bash#323
Merged
natecook1000 merged 1 commit intoJun 10, 2021
Conversation
Member
|
Looks solid @Frizlab — can you fix up the conflicts from your other fix? |
Contributor
Author
|
@natecook1000 Done |
Member
|
@swift-ci Please test |
Contributor
Author
|
Fixed the test that was failing. |
Member
|
@swift-ci Please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Bash, when calling completion for an executable written with full path (e.g.
/opt/brew/bin/example), the completion script might call another executable if another executable with the same name happens to be first in the PATH. (This is particularly annoying when debugging completion in a project!) This PR fixes that.Checklist