Skip to content

Fix executable path when calling custom completion in bash#323

Merged
natecook1000 merged 1 commit into
apple:mainfrom
xcode-actions:bash_custom_completion_fix_executable
Jun 10, 2021
Merged

Fix executable path when calling custom completion in bash#323
natecook1000 merged 1 commit into
apple:mainfrom
xcode-actions:bash_custom_completion_fix_executable

Conversation

@Frizlab
Copy link
Copy Markdown
Contributor

@Frizlab Frizlab commented Jun 3, 2021

In Bash, when calling completion for an executable written with full path (e.g. /opt/brew/bin/example), the completion script might call another executable if another executable with the same name happens to be first in the PATH. (This is particularly annoying when debugging completion in a project!) This PR fixes that.

Checklist

  • I've added at least one test that validates that my change is working, if appropriate
  • I've followed the code style of the rest of the project
  • I've read the Contribution Guidelines
  • I've updated the documentation if necessary

@natecook1000
Copy link
Copy Markdown
Member

Looks solid @Frizlab — can you fix up the conflicts from your other fix?

@Frizlab
Copy link
Copy Markdown
Contributor Author

Frizlab commented Jun 4, 2021

@natecook1000 Done

@natecook1000
Copy link
Copy Markdown
Member

@swift-ci Please test

@Frizlab
Copy link
Copy Markdown
Contributor Author

Frizlab commented Jun 9, 2021

Fixed the test that was failing.

@natecook1000
Copy link
Copy Markdown
Member

@swift-ci Please test

@natecook1000 natecook1000 merged commit 37610bc into apple:main Jun 10, 2021
@Frizlab Frizlab deleted the bash_custom_completion_fix_executable branch June 10, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants