Hide optional flags when a command has too many options#416
Merged
Conversation
The usage string feature that only shows positional args and required options/flags was incorrectly allowing through flags with type `Bool?`.
Member
Author
|
@swift-ci Please test |
tomerd
reviewed
Mar 3, 2022
| help: ArgumentHelp?) -> ArgumentSet | ||
| { | ||
| // The flag is required if initialValue is `nil`, otherwise it's optional | ||
| let helpOptions: ArgumentDefinition.Help.Options = initialValue != nil ? .isOptional : [] |
tomerd
approved these changes
Mar 3, 2022
Member
tomerd
left a comment
tomerd
left a comment
There was a problem hiding this comment.
looks good. one nit about redundant comment
tomerd
added a commit
to tomerd/swift-package-manager
that referenced
this pull request
Mar 3, 2022
motivation: When invoking any unknown or help-triggering `swift package` command in terminal, the suggested invocation always includes the `--enable-dependency-cache` flag. changes: useDependenciesCache flag to be non-optional, since this triggres a bug in argument parser which adds the option to the usage synopsis note: underlying issue fixed in apple/swift-argument-parser#416 rdar://89488586
tomerd
added a commit
to swiftlang/swift-package-manager
that referenced
this pull request
Mar 4, 2022
motivation: When invoking any unknown or help-triggering `swift package` command in terminal, the suggested invocation always includes the `--enable-dependency-cache` flag. changes: useDependenciesCache flag to be non-optional, since this triggres a bug in argument parser which adds the option to the usage synopsis note: underlying issue fixed in apple/swift-argument-parser#416 rdar://89488586
Member
Author
|
@swift-ci Please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The usage string feature that only shows positional args and required options/flags was incorrectly allowing through flags with type
Bool?. For example,--enable-foowas incorrectly visible in the usage string for this type:Checklist