fix: 🐛 Declare GenerateManualPlugin as plugin product#456
Merged
Conversation
Collaborator
|
@swift-ci please test |
Contributor
Author
|
Is this PR good to be merged or do you need anything else? |
Collaborator
|
Yeah it looks good to me but I'd like @natecook1000 to sign off first. |
Contributor
Author
|
Hi @natecook1000, this PR provides the fix for generating man pages from the consumer's package root. Would love to see this getting merged soon :) |
Collaborator
|
I believe Nate will be able to approve this in the upcoming week; sorry about the wait. |
Collaborator
|
Spoke to Nate offline and this looks good. Thanks for your patience! |
Contributor
Author
|
Awesome! What is the ETA for a new release (1.1.4) that will include the fix? After all, the feature to generate man pages is otherwise only working for people pinning to the main branch. |
Collaborator
|
1.1.4 has been released with this fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✅ Closes: #455
ArgumentParser1.1.3 includes a SwiftPM plugin for generating man pages. However, this plugin is not visible to packages that declareArgumentParseras a package dependency.Defining a product of type
pluginin the package manifest will solve that. Runningswift package plugin --listfor a package, that declaresArgumentParseras a package dependency, will then list theGenerateManualPluginChecklist