Skip to content

Fixup help options for built-in flags#474

Merged
rauhul merged 3 commits into
mainfrom
fixup-generated-flags-help-options
Aug 26, 2022
Merged

Fixup help options for built-in flags#474
rauhul merged 3 commits into
mainfrom
fixup-generated-flags-help-options

Conversation

@rauhul
Copy link
Copy Markdown
Collaborator

@rauhul rauhul commented Aug 25, 2022

  • Fixes a bug where built-in flags such as --help and --version were not
    properly marked with isOptional which resulted in them appearing in
    generated content (such as completion scripts and manuals) as required
    arguments.

rauhul added 2 commits August 25, 2022 00:52
- Fixes a manual generation bug where options in the synopsis were not
  given an option value name and flags were.
- Fixes a bug where built-in flags such as --help and --version were not
  properly marked with isOptional which resulted in them appearing in
  generated content (such as completion scripts and manuals) as required
  arguments.
@rauhul
Copy link
Copy Markdown
Collaborator Author

rauhul commented Aug 25, 2022

@swift-ci please test

Copy link
Copy Markdown
Member

@natecook1000 natecook1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@rauhul
Copy link
Copy Markdown
Collaborator Author

rauhul commented Aug 26, 2022

@swift-ci please test

@rauhul rauhul merged commit f1c6afd into main Aug 26, 2022
@rauhul rauhul deleted the fixup-generated-flags-help-options branch August 26, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants