Bash does not like '-' in function names

[kennyyork]

If a ParsableCommand has a commandName value with a hyphen, the bash completion generator will generate a function name with a hyphen which isn't valid in BASH, eg _programName_command_sub-command': not a valid identifier

Checklist

• I've added at least one test that validates that my change is working, if appropriate
• I've followed the code style of the rest of the project
• I've read the Contribution Guidelines
• I've updated the documentation if necessary

[natecook1000]

Thanks so much for working on this, @kennyyork!

It looks like we're already escaping in this way for zsh, and it's probably safe to assume that fish has this same requirement. Could you rename the existing zshEscapingCommandName method to shellEscapingCommandName, and then have all three script generators use that?

[natecook1000]

@swift-ci Please test

[natecook1000]

@swift-ci Please test