Skip to content

Add support for Musl libc#574

Merged
MaxDesiatov merged 3 commits into
mainfrom
maxd/canimport-musl
Jun 28, 2023
Merged

Add support for Musl libc#574
MaxDesiatov merged 3 commits into
mainfrom
maxd/canimport-musl

Conversation

@MaxDesiatov
Copy link
Copy Markdown
Member

Since Musl is sufficiently different from Glibc (see https://wiki.musl-libc.org/functional-differences-from-glibc.html), it requires a different import, which now should be applied to files that have import Glibc in them.

Since Musl is sufficiently different from Glibc (see https://wiki.musl-libc.org/functional-differences-from-glibc.html), it requires a different import, which now should be applied to files that have `import Glibc` in them.
@MaxDesiatov MaxDesiatov requested a review from rauhul June 22, 2023 15:35
@MaxDesiatov
Copy link
Copy Markdown
Member Author

@swift-ci test

Copy link
Copy Markdown
Collaborator

@rauhul rauhul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to see additional libc support!

Glibc and Darwin can share the same `ioctl` code.
@MaxDesiatov
Copy link
Copy Markdown
Member Author

@swift-ci test

@MaxDesiatov
Copy link
Copy Markdown
Member Author

macOS failure is unrelated and is also reproduced in an empty PR #575. @rauhul have you seen this one before?

@natecook1000
Copy link
Copy Markdown
Member

@swift-ci Please test

@MaxDesiatov MaxDesiatov merged commit 7b0f469 into main Jun 28, 2023
@MaxDesiatov MaxDesiatov deleted the maxd/canimport-musl branch June 28, 2023 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants