Remove @_implementationOnly annotations#616
Conversation
|
@swift-ci please test |
keith
force-pushed
the
ks/remove-_implementationonly-annotations
branch
from
5736e59 to
6432e19
Compare
|
@swift-ci please test |
|
@natecook1000 can you review? (sorry I can't add you as a reviewer here) |
|
Is there a reason to use private instead of internal? Additionally could we use an upcoming feature flag instead of conditional compilation? |
|
I don't have a pref on private vs internal for this case, was just trying to mirror similarly to what was here before. But I guess if private works I'd think we should prefer that, wdyt? Based on swiftlang/swift-syntax#2429 (comment) you cannot use that flag instead |
|
I wasn't sure if there was a specific reason to prefer private other than minimally scoped imports. Given the context of the swift-syntax comment, this changes lgtm, but I'll wait for Nate to do the final approval |
These annotations produce warnings when compiling swift-syntax without library evolution using Swift ≥5.10. Replace them by `private import` when compiling using Swift ≥5.11. Mirrors swiftlang/swift-syntax#2429
keith
force-pushed
the
ks/remove-_implementationonly-annotations
branch
from
6432e19 to
51e348b
Compare
|
@swift-ci please test |
3 participants
These annotations produce warnings when compiling swift-syntax without library evolution using Swift ≥5.10.
Replace them by
private importwhen compiling using Swift ≥5.11.Mirrors swiftlang/swift-syntax#2429
Checklist