Updates to support Swift 6 language version#650
Merged
Conversation
Some minor NFC changes to resolve strict concurrency checking warnings/errors and the warning about the change in meaning for `#file`.
Member
Author
|
@swift-ci Please test |
Member
Author
|
@swift-ci Please test |
rauhul
approved these changes
Jun 28, 2024
Collaborator
rauhul
left a comment
rauhul
left a comment
There was a problem hiding this comment.
I dont understand the file -> filePath change but looks right overall
|
|
||
| import Foundation | ||
| #if swift(>=6) | ||
| @preconcurrency import PackagePlugin |
Collaborator
There was a problem hiding this comment.
Hmm it feels like we should file a bug on SwiftPM for this
Member
Author
There was a problem hiding this comment.
I can't reproduce the warnings that led me to add this anymore 😭
Member
Author
|
@swift-ci Please test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some minor NFC changes to resolve strict concurrency checking warnings/errors and the warning about the change in meaning for
#file.