Fix Swift 5.7 build errors#676
Merged
Merged
Conversation
Collaborator
|
@swift-ci please test |
Collaborator
|
I'd love a follow up PR that drops the increases supported version of argument parser to one of 5.9, 5.10, or 6.0. I think 5.9 is most inline with other repos like swift-nio which try to support the last 3 minor releases of Swift. |
Contributor
Author
Collaborator
Contributor
Author
|
Some developers stuck on macOS 12 (therefore Xcode 14.2, therefore Swift 5.7) until M4 Mac Studio release. I'd suggest supporting Swift back to the most recent EOL macOS (currently macOS 12, so Swift 5.7), to give people leeway to purchase the replacement machine they want when their Mac goes EOL. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed all Swift 5.7 build breaks in
main, namely:Package.swift:targetarray missing a commaToolInfo.swift: contains 2 if expressions, which are not supported by Swift 5.7GenerateManual.swift: contains switch expression, which is not supported by Swift 5.7DumpHelpGenerationTests.swift: contains switch expression, which is not supported by Swift 5.7Resolve #675
Checklist