Fix incorrect or confusing documentation about Swift versions#678
Conversation
| @@ -29,14 +29,22 @@ struct CountLines: AsyncParsableCommand { | |||
|
|
|||
| ### Usage in Swift 5.5 | |||
There was a problem hiding this comment.
@natecook1000 what do you think about just dropping this content from the docs? Current ArgumentParser doesn't support 5.5 and users of a version that does can reference older documentation instead.
There was a problem hiding this comment.
@rauhul @natecook1000 What can I do to move this forward?
Thanks.
There was a problem hiding this comment.
@rauhul @natecook1000 I'll be happy to modify this PR however you want to get it resolved.
If you're not sure if you want to delete the 5.5 instructions, it might make sense to accept this PR as is, since it improves the 5.5 instructions. You can then decide whether to keep or delete the 5.5 instructions at your leisure, but at least everything will be updated in the meantime.
There was a problem hiding this comment.
Apologies for the delay on this, @rgoldberg! I think Rauhul is right that we don't need this in the mainline docs anymore, but I don't want it to completely disappear. I can't decide between making a separate article and sticking in the changelog, so why don't we get this merged and I can move it later on.
Thanks!
There was a problem hiding this comment.
Thanks for merging this!
Rewrote Markdown to properly specify Swift 5.7 instead of 5.5, and to clarify other information related to Swift versions. Resolve apple#677 Signed-off-by: Ross Goldberg <484615+rgoldberg@users.noreply.github.com>
rgoldberg
force-pushed
the
677-swift-version-documentation
branch
from
e7369ac to
b63295d
Compare
|
@swift-ci Please test |
3 participants
Fix incorrect or confusing documentation about Swift versions
Rewrote Markdown to properly specify Swift 5.7 instead of 5.5, and to clarify other information related to Swift versions.
Resolve #677
Checklist