Repeated flags fix#71
Merged
Merged
Conversation
Contributor
Author
|
Noting the draft PR #65, specifying the new |
c85ce34 to
01b38e0
Compare
Member
|
@glessard This looks great — I think adding the Can you update with latest and I'll merge? |
- this is equivalent to saying the same thing twice, as opposed to contradicting oneself.
01b38e0 to
849c439
Compare
Contributor
Author
|
I rebased and squashed. Thanks! |
griffin-stewie
pushed a commit
to griffin-stewie/swift-argument-parser
that referenced
this pull request
Mar 11, 2020
- this is equivalent to saying the same thing twice, as opposed to contradicting oneself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stop failing upon seeing a repeated value from a mutually-exclusive set of flags.
This adds an
Equatablerequirement to theFlagconstructors fromCaseIterableenums. Given the other requirements on those enums,Equatableconformance is automatic and therefore costs nothing.The switch statement in
ArgumentSet.updateFlagis also much simplified, by callingvalues.element(forKey:)only when it is needed.Checklist
This fixes #59
This supersedes #70