Use Foundation Essentials when possible#804
Merged
Merged
Conversation
Collaborator
Author
|
@swift-ci test |
Member
|
API breakage reports this, which I'm glad to not be doing any more:
Are you able to measure the impact of this change on binary sizes on Linux/Windows? |
Collaborator
Author
|
This was referenced Sep 9, 2025
2 tasks
natecook1000
added a commit
that referenced
this pull request
Mar 18, 2026
* Fix unknown target type in Swift 5.8 refs #803 `swift package resolve` in Swift 5.8.x: ``` Computing version for https://github.com/apple/swift-argument-parser.git error: Invalid manifest (compiled with: ["/usr/bin/swiftc", "-vfsoverlay", "/tmp/TemporaryDirectory.HCuAi3/vfs.yaml", "-L", "/usr/lib/swift/pm/ManifestAPI", "-lPackageDescription", "-Xlinker", "-rpath", "-Xlinker", "/usr/lib/swift/pm/ManifestAPI", "-swift-version", "5", "-I", "/usr/lib/swift/pm/ManifestAPI", "-package-description-version", "5.8.0", "/Package@swift-5.8.swift", "-Xfrontend", "-disable-implicit-concurrency-module-import", "-Xfrontend", "-disable-implicit-string-processing-module-import", "-o", "/tmp/TemporaryDirectory.RLkqp3/swift-argument-parser-manifest"]) /Package@swift-5.8.swift:149:9: error: type 'Target.TargetType' has no member 'macro' case .macro, .plugin, .system, .binary: ~^~~~~ in https://github.com/apple/swift-argument-parser.git ``` * Fix to remove access level modifier on imports for Swift 5 fix #870 refs #804 If you want without compiler conditional import, enable `InternalImportsByDefault` upcoming feature and remove `internal` from imports. * Fix unsupported conditional attributes in Swift 5.7 refs #794 --------- Co-authored-by: Nate Cook <natecook@apple.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.