[windows] add PDB files to install target#895
Draft
charles-zablit wants to merge 1 commit into
Draft
Conversation
compnerd
requested changes
May 6, 2026
Collaborator
compnerd
left a comment
There was a problem hiding this comment.
install(FILES $<TARGET_PDB_FILE:${module}>
DESTINATION ${CMAKE_INSTALL_BINDIR}
OPTIONAL)
Author
Is there a specific reason for doing it this way instead of the other way around? |
Collaborator
Yes, this makes the code easier to read, this allows CMake to track the dependency properly, and it doesn't require you to know where the PDB is emitted in practice. This is the canonical way that CMake recommends. |
Author
|
I tried this and it fails at configure time: It looks like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of swiftlang/swift#88869.