Fixes issue where the cookie is not present upon redirect in Next.js server-side rendering demo #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
There is currently an issue with Next.js where setting a cookie using
cookies()and then returningNextResponsewill not add the cookie to that response meaning that the session is not set and requires a refresh. This adds the cookie to the response along side setting it usingcookies()to make sure that upon redirecting, the session is present.Test Plan
I manually tested this, both as a fresh install, on existing projects and had confirmation from others that this approach worked when they were using this as repo as a starting point.
Related PRs and Issues
Have you read the Contributing Guidelines on issues?
Yes