feat: Command Line SDK update for version 17.0.0#283
Conversation
* Breaking: Removed `--key` option from `appwrite project update-variable` * Added `documents-db` commands to CLI * Added `vectors-db` commands to CLI * Added docs examples for `documents-db` and `vectors-db` * Added `--variable-id` to `appwrite project create-variable` * Updated API version badge to 1.9.0
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (18)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR updates the Appwrite CLI SDK to version 17.0.0, adding two new service modules ( Key issues found:
Confidence Score: 2/5
Important Files Changed
|
| actionRunner( | ||
| async ({ databaseId, collectionId, data, queries, transactionId }) => | ||
| parse(await (await getDocumentsDBClient()).updateDocuments(databaseId, collectionId, JSON.parse(data), queries, transactionId)), | ||
| ), |
There was a problem hiding this comment.
JSON.parse(undefined) crash on optional --data
--data is defined as an optional .option(...), so when users call update-documents without providing --data, data will be undefined and JSON.parse(undefined) will throw a SyntaxError at runtime.
The same issue affects:
upsert-documentat line 401 (lib/commands/services/documents-db.ts)update-documentat line 417 (lib/commands/services/documents-db.ts)update-documentsat line 378 (lib/commands/services/vectors-db.ts)upsert-documentat line 423 (lib/commands/services/vectors-db.ts)update-documentat line 439 (lib/commands/services/vectors-db.ts)
Guard against undefined before parsing:
| actionRunner( | |
| async ({ databaseId, collectionId, data, queries, transactionId }) => | |
| parse(await (await getDocumentsDBClient()).updateDocuments(databaseId, collectionId, JSON.parse(data), queries, transactionId)), | |
| ), | |
| async ({ databaseId, collectionId, data, queries, transactionId }) => | |
| parse(await (await getDocumentsDBClient()).updateDocuments(databaseId, collectionId, data ? JSON.parse(data) : undefined, queries, transactionId)), |
This PR contains updates to the Command Line SDK for version 17.0.0.