Set severity when output is sarif#336
Open
austimkelly wants to merge 3 commits intoaquasecurity:masterfrom
Open
Set severity when output is sarif#336austimkelly wants to merge 3 commits intoaquasecurity:masterfrom
austimkelly wants to merge 3 commits intoaquasecurity:masterfrom
Conversation
set --severity for SARIF output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix the
--severityflag and values were not added to the sarif input. Hence, when a default value of 'CRITICAL,HIGH' was supplied, it would simply be ignored and report everything. The result is producing a bunch of noisy alerts, and anin't nobody got time for that!Before the fix:
with this PR fix:
