chore: replace deprecated '--slow' with '--parallel'#2555
Open
henkka wants to merge 3 commits intoaquasecurity:mainfrom
Open
chore: replace deprecated '--slow' with '--parallel'#2555henkka wants to merge 3 commits intoaquasecurity:mainfrom
henkka wants to merge 3 commits intoaquasecurity:mainfrom
Conversation
Relates to aquasecurity/trivy#5572 where --slow was deprecated
afdesk
requested changes
May 15, 2025
| } | ||
| if c.GetSlow() { | ||
| return "--slow" | ||
| return "--parallel 1" |
Contributor
There was a problem hiding this comment.
maybe we should support backward compatibility with older tags too
--slow was deprecated in v0.53.0 aquasecurity/trivy#7061
Author
There was a problem hiding this comment.
Thank you for the quick turnaround! Fixed with fa22696
Contributor
|
@henkka thanks for your contribution |
Contributor
|
@simar7 should we change a flag trivy-operator/pkg/plugins/trivy/flags.go Lines 22 to 35 in fb9add8 |
afdesk
approved these changes
May 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to aquasecurity/trivy#5572 where --slow was deprecated in the
trivyproject.With current implementation, each scan job logs the following warning:
This pull request modifies
trivy-operatorto use the--parallel 1instead of the deprecated--slowflag, while keeping thetrivy-operator's own API backward compatible (ie. call itslowbut under the hood convert it toparallel)