Skip to content

Supported extra whitespaces where I needed them + many other changes #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arran4 wants to merge 27 commits into
base: master
Choose a base branch
from
Open

Supported extra whitespaces where I needed them + many other changes #151

Changes from 1 commit
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
335c1f9
added some actions
arran4 Feb 15, 2023
26d95ba
My issue
arran4 Feb 15, 2023
5335e6f
Error return value is not checked (errcheck)
arran4 Feb 15, 2023
14cb70e
field `offsetlen` is unused (unused)
arran4 Feb 15, 2023
2fb4c46
S1021: should merge variable declaration with assignment on next line…
arran4 Feb 15, 2023
5143d47
S1023: redundant break statement (gosimple)
arran4 Feb 15, 2023
57a1767
SA4006: this value of `err` is never used (staticcheck)
arran4 Feb 15, 2023
ad0ab84
Lint action out of date.
arran4 Feb 15, 2023
a8e238d
Go mod tidy
arran4 Feb 15, 2023
e654ac7
Bug fixes.
arran4 Feb 15, 2023
cefe5b3
More typo changes
arran4 Feb 15, 2023
4345a38
Another error
arran4 Feb 15, 2023
515cd81
S1023: redundant break statement (gosimple)
arran4 Feb 15, 2023
eabb56b
Text should be lowercase
arran4 Feb 15, 2023
c5b562a
Added go releaser
arran4 Feb 15, 2023
094aad3
Commented code
arran4 Feb 15, 2023
53a8cbd
Unnecessary bracket
arran4 Feb 15, 2023
544b542
Test improvements.. I think
arran4 Feb 15, 2023
c5a1edc
My addition last
arran4 Feb 15, 2023
268a690
So people don't have to check the string they can use the new errors.…
arran4 Feb 15, 2023
bf3a5b3
Skip white space - to delete strategically
arran4 Feb 15, 2023
3a32cbb
All of these did nothing
arran4 Feb 15, 2023
b1fd89e
The only required one.
arran4 Feb 15, 2023
19ef6a2
New failure - still white space
arran4 Feb 15, 2023
8b765a5
Skip white space
arran4 Feb 15, 2023
b0b5409
Unused code
arran4 Feb 15, 2023
01b692d
Another case.
arran4 Feb 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
S1023: redundant break statement (gosimple)
  • Loading branch information
@arran4
arran4 authored Feb 15, 2023
commit 5143d47e3e263c4fee712bf3cb87cd54edbe0298
2 changes: 0 additions & 2 deletions parseany.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1442,7 +1442,6 @@ iterRunes:
if datestr[i-1] == 'm' {
p.extra = i - 2
p.trimExtra()
break
}
case '+', '-', '(':
// This really doesn't seem valid, but for some reason when round-tripping a go date
Expand All @@ -1452,7 +1451,6 @@ iterRunes:
p.extra = i - 1
p.stateTime = timeWsOffset
p.trimExtra()
break
default:
switch {
case unicode.IsDigit(r):
Expand Down