Skip to content

ANW-258: More PDF tweaks#3021

Merged
brianzelip merged 12 commits intomasterfrom
ANW-258-rework
Nov 3, 2023
Merged

ANW-258: More PDF tweaks#3021
brianzelip merged 12 commits intomasterfrom
ANW-258-rework

Conversation

@avatar382
Copy link
Copy Markdown
Collaborator

Description

Various changes to improve Staff PDF rendering and make the PUI PDF be as close to possible to the staff PDF

Related JIRA Ticket or GitHub Issue

https://archivesspace.atlassian.net/browse/ANW-258

How Has This Been Tested?

Manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@quoideneuf quoideneuf marked this pull request as draft August 11, 2023 14:54
@avatar382 avatar382 marked this pull request as ready for review October 30, 2023 16:54
@brianzelip brianzelip self-assigned this Oct 31, 2023
@brianzelip brianzelip self-requested a review October 31, 2023 15:32
Copy link
Copy Markdown
Collaborator

@brianzelip brianzelip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement.

@brianzelip brianzelip merged commit 12d66d0 into master Nov 3, 2023
@brianzelip brianzelip deleted the ANW-258-rework branch November 3, 2023 17:19
@cdibella cdibella added this to the 3.5.0 milestone Feb 7, 2024
thimios pushed a commit that referenced this pull request Apr 4, 2024
* fix for italic& bold fonts not working with Noto Sans in PUI PDF

* in PDF collection inventory, only treat as a heading as per staff PDF

... that is, if is a collection, series, or subseries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants