Remove paginate

[MarkusGnigler]

I removed the obsolete Paginate method from issue Remove obsolete Paginate builder action..

Hope this change was sufficient.

[fiseni]

Hey @MarkusGnigler,

Thank you for your help. In the issue, I also mentioned the IsPagingEnabled property. Please can you remove that too? It's no longer necessary.

[MarkusGnigler]

Hy @fiseni,

oh sure, it's a better exception message. Thanks for your guidance.

I also remove the IsPagingEnabled prop, sorry for the overlooking.

[MarkusGnigler]

Should I also refactor the skip and take builder tests to use more the FluentAssertion library, or is using classic assertions the preferred approach since it's shorter?

Tests are located in:

• Ardalis.Specification.UnitTests.SpecificationBuilderExtensions_Skip
• Ardalis.Specification.UnitTests.SpecificationBuilderExtensions_Take

[Fact]
public void ThrowsDuplicateSkipException_GivenSkipUsedMoreThanOnce()
{
    Assert.Throws<DuplicateSkipException>(() => new StoreDuplicateSkipSpec());
}

[Fact]
public void ThrowsDuplicateSkipException_GivenSkipUsedMoreThanOnce()
{
    Action sutAction = () => new StoreDuplicateSkipSpec();

    sutAction.Should()
        .Throw<DuplicateSkipException>();
}

[fiseni]

I don't mind really. Since we're using fluent assertions in all other places, you can refactor it if you want, so we're consistent.

[MarkusGnigler]

The consistent aspect was my first intention.

Should i scan other places as well?

By me it's already evening, I'll try to commit in the next few days.

Wish you a happy new year

[fiseni]

No worries, take your time. Yes, you can refactor other places too. Thank you for the help, it's appreciated.

Happy New Year!

[fiseni]

Hey @MarkusGnigler. You requested a review but I don't see any new commits. Do you want me to merge it as it is, or do you want to work on the tests?

[MarkusGnigler]

Hi @fiseni.

Sry, i think the requested review was a mistake.

I don't know, should i create a new PR for the test refactoring or should i stick to the existing one?

[MarkusGnigler]

Hi @fiseni

I've decided to commit the test assertions to this pr as well, since it's not that big impact.

I hope it's ok for you?

[fiseni]

Thanks for the help!

[MarkusGnigler]

Thank you as well for your friendly communication and guidance!