DigitalOutputs writeAll function not correctly writing to each Output

[kevmk04]

When using the writeAll function for Digital Outputs, the function will only turn on/off all Outputs regardless of input integer. For example, supplying any value greater than zero will turn ON all Outputs. Providing a zero will turn OFF all Outputs.

Function source code is here:

Arduino_PortentaMachineControl/src/DigitalOutputsClass.cpp

Line 78 in 563b200

void DigitalOutputsClass::writeAll(uint8_t val_mask) {

Within the function, it appears that the logical (&&) operator is being used where a bitwise (&) should be. I was able to test this with a Portenta Machine Control and confirmed that switching the operator fixes the issue and allows the integer to be correctly parsed into the individual outputs.

Line w/ Operator:

Arduino_PortentaMachineControl/src/DigitalOutputsClass.cpp

Line 80 in 563b200

if (val_mask && (1 << ch)) {

[kevmk04]

I'm happy to create a PR for this fix if desired.

[facchinm]

Ah good catch, can you submit a PR that I'll merge immediately? Just to keep track of the authorship 🙂

[leonardocavagnis]

Dear @kevmk04,
We're waiting for the PR 😉

[kevmk04]

Sorry for the delay, missed the notifications. PR is up for your review!