Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove check-python-task and the related unused dependencies
  • Loading branch information
MatteoPologruto committed Dec 15, 2022
commit be4c47aa38bf261f3b2fb09d3e95769e11c82e3f
16 changes: 0 additions & 16 deletions .flake8

This file was deleted.

86 changes: 0 additions & 86 deletions .github/workflows/check-python-task.yml

This file was deleted.

17 changes: 0 additions & 17 deletions Taskfile.yml
Original file line number Diff line number Diff line change
Expand Up @@ -235,22 +235,6 @@ tasks:
cmds:
- clang-format -i rpc/cc/arduino/cli/*/*/*.proto

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-python-task/Taskfile.yml
python:format:
desc: Format Python files
deps:
- task: poetry:install-deps
cmds:
- poetry run black .

# Source: https://github.com/arduino/tooling-project-assets/blob/main/workflow-templates/assets/check-python-task/Taskfile.yml
python:lint:
desc: Lint Python code
deps:
- task: poetry:install-deps
cmds:
- poetry run flake8 --show-source

build:
desc: Build the project
deps:
Expand Down Expand Up @@ -288,7 +272,6 @@ tasks:
cmds:
- task: go:vet
- task: go:lint
- task: python:lint
- task: protoc:check

check-legacy:
Expand Down
17 changes: 0 additions & 17 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -187,23 +187,6 @@ To run very specific test functions:
go test -v github.com/arduino/arduino-cli/internal/integrationtest/lib -run TestLibUpgradeCommand
```

#### Linting and formatting

When editing any Python file in the project remember to run linting checks with:

```shell
task python:lint
```

This will run `flake8` automatically and return any error in the code formatting, if not already installed it will also
install integration tests dependencies.

In case of linting errors you should be able to solve most of them by automatically formatting with:

```shell
task python:format
```

### Dependency license metadata

Metadata about the license types of all dependencies is cached in the repository. To update this cache, run the
Expand Down
Loading