Skip to content

[skip changelog] Bump golangci/golangci-lint-action from 6 to 7 #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmaglie merged 10 commits into from
Apr 3, 2025
Merged

[skip changelog] Bump golangci/golangci-lint-action from 6 to 7 #2872

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
52e59ad
[skip changelog] Bump golangci/golangci-lint-action from 6 to 7
dependabot[bot] Mar 25, 2025
0441aa9
Migrated golanci.yml to v2
cmaglie Mar 31, 2025
7173c0d
Updated golangci-lint version used in GH workflows
cmaglie Mar 31, 2025
4beccdf
Fixed linter warning
cmaglie Mar 31, 2025
d834ac1
Fixed linter warning
cmaglie Mar 31, 2025
2709c00
Fixed linter warnings
cmaglie Mar 31, 2025
48ede6b
Fixed linter warnings
cmaglie Mar 31, 2025
494679a
Fixed linter warning
cmaglie Mar 31, 2025
fd5b7da
Fixed linter warning
cmaglie Mar 31, 2025
f69bff3
Fixed linter warning
cmaglie Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixed linter warning 
commands/service_compile.go:162:5: QF1001: could apply De Morgan's law (staticcheck)
        if !(keychainProp == signProp && signProp == encryptProp) {
  • Loading branch information
@cmaglie
cmaglie committed Mar 31, 2025
commit 4beccdf4186705253449dd285d56a2c6bb81a05d
2 changes: 1 addition & 1 deletion commands/service_compile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ func (s *arduinoCoreServerImpl) Compile(req *rpc.CompileRequest, stream rpc.Ardu
signProp := boardBuildProperties.ContainsKey("build.keys.sign_key")
encryptProp := boardBuildProperties.ContainsKey("build.keys.encrypt_key")
// we verify that all the properties for the secure boot keys are defined or none of them is defined.
if !(keychainProp == signProp && signProp == encryptProp) {
if keychainProp != signProp || signProp != encryptProp {
return errors.New(i18n.Tr("Firmware encryption/signing requires all the following properties to be defined: %s", "build.keys.keychain, build.keys.sign_key, build.keys.encrypt_key"))
}

Expand Down