Skip to content

Add a cleanup/exit callback to CheckForUpdates #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
giulio93 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add a cleanup/exit callback to CheckForUpdates #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions updater/updater.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import (

// UpgradeConfirmCB is a function that is called when an update is ready to be applied.
type UpgradeConfirmCB func(current, target releaser.Version) bool
type CleanupCB func() error

var DefaultUpgradeConfirmCb = func(current, target releaser.Version) bool { return true }

Expand All @@ -32,7 +33,7 @@ var DefaultUpgradeConfirmCb = func(current, target releaser.Version) bool { retu
// If an update is applied, it will restart the application with the new version.
// If no update is available, it will return nil.
// If an error occurs during the update process, it will return the error.
func CheckForUpdates(targetPath string, current releaser.Version, client *releaser.Client, upgradeCb UpgradeConfirmCB) error {
func CheckForUpdates(targetPath string, current releaser.Version, client *releaser.Client, upgradeCb UpgradeConfirmCB, cleanup CleanupCB) error {
restartPath, err := apply(targetPath, current, client, upgradeCb)
if err != nil {
return err
Expand All @@ -45,7 +46,12 @@ func CheckForUpdates(targetPath string, current releaser.Version, client *releas
if err := execApp(restartPath); err != nil {
return fmt.Errorf("update applied, but failed to restart application: %w", err)
}
// TODO: allow to define custom "exit"

if cleanup != nil {
if err := cleanup(); err != nil {
return fmt.Errorf("cleanup failed: %w", err)
}
}
Comment on lines +50 to +54
Copy link
Contributor

@lucarin91 lucarin91 Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be clever here. A long cleanup procedure could interfere with the execApp above. If the app is set to have only one instance, the exec above will fail because the app will run the cleanup while the new one starts. I would say that at least the cleanup should be done before the execApp. But I am wondering if the caller should also run its exit code. Run our self os.Exit is risky because it will prevent the caller from running the deferred functions, so maybe something will not be correctly cleaned.

os.Exit(0)
return nil
}
Loading