Migrate core Hera classes to dataclasses (dropping Pydantic)#1547
Merged
elliotgunton merged 8 commits intomainfrom Jan 29, 2026
Merged
Migrate core Hera classes to dataclasses (dropping Pydantic)#1547elliotgunton merged 8 commits intomainfrom
elliotgunton merged 8 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1547 +/- ##
=======================================
+ Coverage 80.4% 81.1% +0.6%
=======================================
Files 63 63
Lines 5144 5267 +123
Branches 821 824 +3
=======================================
+ Hits 4140 4273 +133
+ Misses 858 847 -11
- Partials 146 147 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9f13642 to
87417b4
Compare
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
87417b4 to
1a6aa96
Compare
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
* Remove badly-named deprecated volume classes Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
aa99286 to
08cccc2
Compare
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
7d555a4 to
3744a3a
Compare
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
This PR will be used as the base branch for #1544, starting in this PR with the Archive, Env and EnvFrom classes being converted to
dataclassesas they are the simplest classes that show the proof of concept for converting to dataclasses (in this case, it's effectively a "one-liner" to remove theBaseModelparent class and use@dataclassinstead). And then continuing with the internals of Hera which can be converted without generating new API classes. We can then generate those API classes and fix the minor issues that appear.