Migrate mixin classes to dataclasses#1548
Merged
elliotgunton merged 11 commits intomainfrom Feb 4, 2026
Merged
Conversation
elliotgunton
changed the title
elliotgunton
changed the title
elliotgunton
added
type:enhancement
jeongukjae
reviewed
Jan 25, 2026
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
* `test_unit` folder all passing * Artifact and Parameter remaining to migrate Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
* Temporarily disable roundtrip check in tests (CronWorkflow tests failing) * All test_hera_output tests passing Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
* Due to extra="forbid" on the model, I discovered various typos and invalid code. e.g. `Artifact` never had a `description`, even though it was in the tests Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
elliotgunton
force-pushed
the
migrate-mixin-classes
branch
from
460d9c5 to
6276088
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1548 +/- ##
=======================================
+ Coverage 81.1% 81.3% +0.2%
=======================================
Files 63 63
Lines 5267 5362 +95
Branches 824 825 +1
=======================================
+ Hits 4273 4361 +88
- Misses 847 852 +5
- Partials 147 149 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
elliotgunton
force-pushed
the
migrate-mixin-classes
branch
from
de91624 to
27c715f
Compare
* Plus other tidy ups Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
elliotgunton
force-pushed
the
migrate-mixin-classes
branch
from
27c715f to
57be54b
Compare
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
Signed-off-by: Elliot Gunton <elliotgunton@gmail.com>
jeongukjae
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Description of PR
Migrate the remaining core components of Hera that involve the use of the "Mixins".