Remove decorator feature#1556
Merged
elliotgunton merged 9 commits intoargoproj-labs:mainfrom Feb 18, 2026
Merged
Conversation
Signed-off-by: Ukjae Jeong <jeongukjae@gmail.com>
jeongukjae
added
type:task
jeongukjae
commented
Feb 16, 2026
Collaborator
Author
There was a problem hiding this comment.
removed from mkdocs.yaml on purpose not to expose this in index
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1556 +/- ##
=======================================
- Coverage 81.2% 80.4% -0.9%
=======================================
Files 63 62 -1
Lines 5355 5103 -252
Branches 820 777 -43
=======================================
- Hits 4350 4104 -246
- Misses 855 863 +8
+ Partials 150 136 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jeongukjae
requested review from
alicederyn,
elliotgunton and
sambhav
as code owners
Collaborator
elliotgunton
left a comment
elliotgunton
left a comment
There was a problem hiding this comment.
Looks good, minor fixes 🚀
Co-authored-by: Elliot Gunton <elliotgunton@gmail.com> Signed-off-by: Ukjae Jeong <JeongUkJae@gmail.com>
Signed-off-by: Ukjae Jeong <JeongUkJae@gmail.com>
Signed-off-by: Ukjae Jeong <JeongUkJae@gmail.com>
Signed-off-by: Ukjae Jeong <JeongUkJae@gmail.com>
alicederyn
reviewed
Feb 17, 2026
Co-authored-by: Elliot Gunton <elliotgunton@gmail.com> Signed-off-by: Ukjae Jeong <JeongUkJae@gmail.com>
Signed-off-by: Ukjae Jeong <JeongUkJae@gmail.com>
jeongukjae
force-pushed
the
remove-decorator
branch
from
5ebc02e to
be15e25
Compare
…ecation Signed-off-by: Ukjae Jeong <JeongUkJae@gmail.com>
elliotgunton
approved these changes
Feb 18, 2026
Collaborator
There was a problem hiding this comment.
LGTM! Giving @alicederyn a chance for a second look before merging though 🚀
alicederyn
reviewed
Feb 18, 2026
| varname = {version = ">=0.13.1,<0.16.0", optional = true} | ||
| black = {version = ">=24.1.0", optional = true} | ||
| httpx = {version = "^0.28.1", optional = true} | ||
| typing-extensions = ">=4.5.0" |
Collaborator
There was a problem hiding this comment.
I think we also want python_version < "3.13"
And/or to update the poetry.lock
Collaborator
Author
There was a problem hiding this comment.
makes sense. added
Signed-off-by: Ukjae Jeong <JeongUkJae@gmail.com>
alicederyn
approved these changes
Feb 18, 2026
elliotgunton
added
the
type:informational
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Fixes #Description of PR
As discussed in maintainer catchup, this pr