fix(api-client): fix retry failing and add a timeout of 30s#305
Merged
Conversation
gregberge
requested review from
a team,
Copilot and
jsfez
and removed request for
a team
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jsfez
approved these changes
May 20, 2026
There was a problem hiding this comment.
Pull request overview
This PR refactors the API client’s custom fetch implementation to make retries reliable (by recreating requests and replaying the body) and introduces a default 30s request timeout, backed by new Vitest unit tests.
Changes:
- Extract retry/timeout logic into a new
apiFetchhelper and wire it intocreateClient. - Add
apiFetchunit tests covering retry behavior, non-retryable 4xx, exhaustion behavior, and timeout aborts. - Add
vitest+ atestscript to@argos-ci/api-client(and update the lockfile accordingly).
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pnpm-lock.yaml | Adds Vitest entry for the api-client workspace importer. |
| packages/api-client/src/index.ts | Uses shared apiFetch implementation and re-exports APIError. |
| packages/api-client/src/fetch.ts | Introduces apiFetch with request recreation, retries, and timeout support. |
| packages/api-client/src/fetch.test.ts | Adds Vitest coverage for retry, body replay, and timeout behavior. |
| packages/api-client/package.json | Adds vitest devDependency and a test script. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.