chore: refactor to depend on latest plonky3#31
Closed
adr1anh wants to merge 3 commits into
Closed
Conversation
Contributor
|
This should by now be made obsolete by our sp1 branch, which contents are equivalent to argumentcomputer/Plonky3#9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes the target of plonky3 from
sp1-devtoplonky3/dev.The main changes are a slight change in the recursion module to adapt the FRI proof types.
TODOs:
test_fri_verify_shape_and_sample_challengesStarkProvingKey,SphinxProvingKeyCloneagain (this requires thePcs::ProverDataassociated type to be madeClonetoo.Note: this PR requires a few changes in
plonky3, which are in the accompanying plonky3/sphinx-compat