Skip to content

ci: Optimize latency and set SP1_DEV #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wwared merged 2 commits into from
Jun 24, 2024
Merged

ci: Optimize latency and set SP1_DEV #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33089d5
ci: Optimize latency and set SP1_DEV
huitseeker Jun 24, 2024
e946057
fix: Rebuild artifacts in test_verifier_export
wwared Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .config/nextest.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ limited = { max-threads = 4 }
very-limited = { max-threads = 1 }

[[profile.ci.overrides]]
filter = '(test(syscall::precompiles) | test(stark::machine) | package(sphinx-recursion-program) | package(sphinx-recursion-circuit))'
filter = '(test(syscall::precompiles) | test(stark::machine) | test(test_verifier_export) | package(sphinx-recursion-program) | package(sphinx-recursion-circuit))'
test-group = 'limited'

[[profile.ci.overrides]]
Expand Down
3 changes: 2 additions & 1 deletion .github/actions/setup/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ inputs:
description: "Token to use for private repo access"
required: true
perf:
description: "Set env to optimize performance"
description: "Set env to optimize CI latency"
required: false
default: "true"
runs:
Expand All @@ -21,6 +21,7 @@ runs:
if [[ "${{ inputs.perf }}" == "true" ]]; then
echo "RUSTFLAGS=${{env.RUSTFLAGS}} -Copt-level=3 -Cdebug-assertions -Coverflow-checks=y -Cdebuginfo=0 -Ctarget-cpu=native" | tee -a $GITHUB_ENV
echo "FRI_QUERIES=1" | tee -a $GITHUB_ENV
echo "SP1_DEV=true" | tee -a $GITHUB_ENV
fi
echo "CARGO_NET_GIT_FETCH_WITH_CLI=true" | tee -a $GITHUB_ENV
echo "RUST_LOG=info" | tee -a $GITHUB_ENV
Expand Down
7 changes: 5 additions & 2 deletions sdk/src/artifacts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ pub use sphinx_prover::build::{

/// Exports the solidity verifier for PLONK proofs to the specified output directory.
///
/// WARNING: If you are on development mode, this function assumes that the PLONK artifacts have
/// already been built.
/// WARNING: If you are on development mode, this function will rebuild the PLONK artifacts.
pub fn export_solidity_plonk_bn254_verifier(output_dir: impl Into<PathBuf>) -> Result<()> {
let output_dir: PathBuf = output_dir.into();
let artifacts_dir = if sphinx_prover::build::sphinx_dev_mode() {
Expand All @@ -21,6 +20,10 @@ pub fn export_solidity_plonk_bn254_verifier(output_dir: impl Into<PathBuf>) -> R
};
let verifier_path = artifacts_dir.join("SphinxVerifier.sol");

if !verifier_path.exists() && sphinx_prover::build::sphinx_dev_mode() {
build_plonk_bn254_artifacts_with_dummy(artifacts_dir);
}

if !verifier_path.exists() {
return Err(anyhow::anyhow!(
"verifier file not found at {:?}",
Expand Down