impl CanonicalSerde for Powers, and PartialEq for params and keys#84
Merged
Pratyush merged 5 commits intoAug 5, 2021
Conversation
Member
|
just one quick question related to the PR: so the PartialEq is added for serialization? |
Contributor
|
No, For example, the predicate identifier in zexe: |
Pratyush
reviewed
Aug 4, 2021
Pratyush
reviewed
Aug 4, 2021
Pratyush
reviewed
Aug 4, 2021
Member
Pratyush
left a comment
There was a problem hiding this comment.
LGTM modulo these small changes
Contributor
Author
|
Thanks, and fixed. |
Member
|
btw, for the hashing, you should note that the |
Pratyush
approved these changes
Aug 4, 2021
CanonicalSerde for Powers, and PartialEq for params and keys
nmohnblatt
added a commit
to geometryxyz/poly-commit
that referenced
this pull request
Jun 29, 2022
…s and keys (arkworks-rs#84)" This reverts commit cafc05e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
serdesforPowersPartialEqforUniversalParamsandVerifierKeyBefore we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Files changedin the Github PR explorernot relevant
Pendingsection inCHANGELOG.md