Skip to content

Update dependencies of algebra, std and curves repos#90

Merged
weikengchen merged 2 commits into
arkworks-rs:masterfrom
huyuncong:master
Jan 26, 2022
Merged

Update dependencies of algebra, std and curves repos#90
weikengchen merged 2 commits into
arkworks-rs:masterfrom
huyuncong:master

Conversation

@huyuncong
Copy link
Copy Markdown
Member

@huyuncong huyuncong commented Jan 19, 2022

Description

Use the latest version of algebra, std, and curves repos instead of v3.0.
In particular, there are the following changes:

  • VariableBaseMSM => VariableBase
  • FixedBaseMSM => FixedBase
  • multi_scalar_mul => msm

There is one problem with test_rng() function in the std repo, and I do not know how to fix it.
The function returns "impl Rng" but it is not clear how to use it in the test of lib.rs.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to Github issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@weikengchen
Copy link
Copy Markdown
Member

weikengchen commented Jan 26, 2022

The problem regarding impl Rng is solved by a not very elegant solution: using Chacha20Rng throughout the test.

It is difficult to bypass because we need to pass a function that handles arbitrary Rng, but Rng cannot be boxed.
(RngCore can, but arkworks is using more than RngCore.)

@weikengchen weikengchen merged commit 4d78d53 into arkworks-rs:master Jan 26, 2022
nmohnblatt added a commit to geometryxyz/poly-commit that referenced this pull request Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants