Merged
Conversation
aballano
commented
Feb 23, 2019
aballano
commented
Feb 23, 2019
pakoito
reviewed
Feb 23, 2019
aballano
commented
Feb 23, 2019
modules/docs/arrow-docs/docs/docs/effects/fx/polymorphism/README.md
Outdated
Show resolved
Hide resolved
aballano
commented
Feb 23, 2019
Otherwise it won't print properly
Member
|
is this still relevant with latest from master? |
added 2 commits
March 15, 2019 17:56
43cd82d to
bb0bc40
Compare
aballano
commented
Mar 15, 2019
modules/docs/arrow-docs/docs/docs/effects/fx/polymorphism/README.md
Outdated
Show resolved
Hide resolved
raulraja
approved these changes
Mar 16, 2019
Member
|
Thanks @aballano! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
effects/fx/README.md-> Removed ank fromsuspend compositionexample since there's no main function and the example doesn't need it.effects/fx/async/README.md-> Fixed example inCancellationby moving the destructuring to a function since "Destructuring declarations are only allowed for local variables/values".effects/fx/polymorphism/README.md->k()call for the conversion fromListtoListK. Also changed the binding to!as it's more explicit and less error-prone than destructuring, which also works for lists.