Skip to content

Fixes for FX docs#1313

Merged
raulraja merged 11 commits intomasterfrom
ab/fix_fx_docs
Mar 16, 2019
Merged

Fixes for FX docs#1313
raulraja merged 11 commits intomasterfrom
ab/fix_fx_docs

Conversation

@aballano
Copy link
Member

@aballano aballano commented Feb 23, 2019

  • Fixed some small errors causing the docs samples not to run properly.
    • effects/fx/README.md -> Removed ank from suspend composition example since there's no main function and the example doesn't need it.
    • effects/fx/async/README.md -> Fixed example in Cancellation by moving the destructuring to a function since "Destructuring declarations are only allowed for local variables/values".
    • effects/fx/polymorphism/README.md ->
      • Fixed one of the examples by converting an expression body main function to block body.
      • Fixed another by adding the k() call for the conversion from List to ListK. Also changed the binding to ! as it's more explicit and less error-prone than destructuring, which also works for lists.

@aballano aballano requested a review from a team February 23, 2019 16:19
Otherwise it won't print properly
@raulraja
Copy link
Member

raulraja commented Mar 1, 2019

is this still relevant with latest from master?

@aballano aballano marked this pull request as ready for review March 16, 2019 17:24
@raulraja raulraja merged commit 06e3eec into master Mar 16, 2019
@raulraja raulraja deleted the ab/fix_fx_docs branch March 16, 2019 19:49
@raulraja
Copy link
Member

Thanks @aballano!

@raulraja raulraja mentioned this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants