Update kotlintest to version 3.3.1#1338
Merged
jrgonzalezg merged 9 commits intoarrow-kt:masterfrom Mar 12, 2019
Merged
Conversation
pakoito
approved these changes
Mar 8, 2019
Member
|
The build pauses after |
pakoito
reviewed
Mar 8, 2019
modules/core/arrow-extras-data/src/main/kotlin/arrow/data/Moore.kt
Outdated
Show resolved
Hide resolved
Law updated because the function has to be suspended NumberMonoid updated because nesting is not supported and I had to create some generators Moore updated because the default toString implementation breaks kotlin-reflect
LordRaydenMK
force-pushed
the
stojan_update_kotlintest
branch
from
586a098 to
6785291
Compare
pakoito
reviewed
Mar 8, 2019
| Gen.choose(Short.MIN_VALUE.toInt(), Short.MAX_VALUE.toInt()).map { it.toShort() } | ||
|
|
||
| fun Gen.Companion.byte(): Gen<Byte> = | ||
| Gen.int().filter { it >= Byte.MIN_VALUE && it <= Byte.MAX_VALUE }.map { it.toByte() } |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Law updated because the function has to be suspended.
NumberMonoid updated because nesting is not supported and I had to create some generators.
Moore updated because the default
toStringimplementation breaks kotlin-reflect.Fixes #1330
thanks @pakoito for the help 😄