Skip to content

Updated Gradle and some dependencies including Kotlin#1343

Merged
jrgonzalezg merged 6 commits intomasterfrom
jrgonzalezg-update-gradle-and-some-dependencies
Mar 12, 2019
Merged

Updated Gradle and some dependencies including Kotlin#1343
jrgonzalezg merged 6 commits intomasterfrom
jrgonzalezg-update-gradle-and-some-dependencies

Conversation

@jrgonzalezg
Copy link
Member

  • Updated Gradle to 5.2.1 through a configured gradle wrapper task (running gradle wrapper updates it to the version configured in the task on the main build.gradle file).
  • Changed several additional build.gradle files cause the kapt plugin was applied too late causing the builds to fail with latest stable Kotlin.
  • For some reason the last Gradle Version plugin does not work with Arrow's repo. I have reported it here: Version 0.21.0 not working for root directory in Arrow's multiproject build ben-manes/gradle-versions-plugin#295
  • There are some additional dependencies that could still be updated but that probably requires some additional migration / restructuring so I have skipped them for this PR.

@jrgonzalezg jrgonzalezg self-assigned this Mar 9, 2019
kotlinxCoroutinesVersion = '1.1.1'
projectReactorVersion = '3.2.6.RELEASE'
retrofitVersion = '2.5.0'
rxJavaVersion = '2.2.7'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BERRY BERRY KLEAN

@jrgonzalezg jrgonzalezg force-pushed the jrgonzalezg-update-gradle-and-some-dependencies branch 2 times, most recently from 30c3467 to 6e0d975 Compare March 9, 2019 12:53
@jrgonzalezg jrgonzalezg force-pushed the jrgonzalezg-update-gradle-and-some-dependencies branch 3 times, most recently from 92a3f0c to ce3f71c Compare March 12, 2019 07:22
@jrgonzalezg
Copy link
Member Author

Update of Gradle seems to be blocked by https://github.com/Takhion/kotlin-metadata__kotlin-compiler-lite bringing dependencies from 1.2.40 into the build which conflict with the version of Kotlin included on recent Gradle versions. May improve if a new version is merged including this: Takhion/kotlin-metadata__kotlin-compiler-lite#1 although that is still on 1.3.11 and not 1.3.21.

@jrgonzalezg jrgonzalezg force-pushed the jrgonzalezg-update-gradle-and-some-dependencies branch 5 times, most recently from fe46cb5 to 5305c47 Compare March 12, 2019 11:41
…ding Kotlin. Tweaked some gradle files to change where kapt plugin is applied to make it possible to use them with latest stable Kotlin version.
…tadata's compiler using a conflicting version of Kotlin
@jrgonzalezg jrgonzalezg force-pushed the jrgonzalezg-update-gradle-and-some-dependencies branch from 5305c47 to b51ca53 Compare March 12, 2019 16:35
@jrgonzalezg jrgonzalezg force-pushed the jrgonzalezg-update-gradle-and-some-dependencies branch from b51ca53 to 5cfea75 Compare March 12, 2019 16:39
…a custom outputFormatter is used so it needed additional setup to print the report. This may be improved later by hooking to the resolution strategy instead of the outputFormatter for what we are doing.
…ng properly with None / Some with latest Kotlin 1.3.21 but works on 1.3.11.
@jrgonzalezg jrgonzalezg merged commit b5e53d8 into master Mar 12, 2019
@jrgonzalezg jrgonzalezg deleted the jrgonzalezg-update-gradle-and-some-dependencies branch March 12, 2019 23:48
@raulraja raulraja mentioned this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants