Skip to content

Docs Arrow version selector#1360

Merged
calvellido merged 14 commits intomasterfrom
paolo-arrow-1309-doc-version-selector
Mar 16, 2019
Merged

Docs Arrow version selector#1360
calvellido merged 14 commits intomasterfrom
paolo-arrow-1309-doc-version-selector

Conversation

@AntonioMateoGomez
Copy link
Collaborator

This PR closes #1309

That's how it would look. We have incorporated an information bar that highlights the version of the library in which we are. At the moment in which the user closes it, you will no longer appear. We do not want it to be a nuisance.

Captura de pantalla 2019-03-13 a las 10 42 05

We have chosen to give importance to the middle button (stable version) in the masthead using the highlight of colors instead of changing its size so that the design continues having a better disposition

@pakoito
Copy link
Member

pakoito commented Mar 13, 2019

Do we only want to keep 3 versions?

@AntonioMateoGomez
Copy link
Collaborator Author

We will keep all the versions, but the top bar and the buttons will show just PREVIOUS, STABLE and NEXT . Clicking in documentation in the nav bar will show all the versions, we have got the same in the docs sidebar.

Captura de pantalla 2019-03-13 a las 11 26 52

Captura de pantalla 2019-03-13 a las 11 27 57

The oldest versions will appear below the 3 that are shown in the screenshot as It shows below. V.0.1.0 and v.0.2.0 are not real data, it is just to have an idea of how it will look like.

Captura de pantalla 2019-03-13 a las 11 32 02

@pakoito
Copy link
Member

pakoito commented Mar 13, 2019

thanks!

@JorgeCastilloPrz
Copy link
Member

Great job 👏👏👏

@calvellido calvellido changed the title Paolo arrow 1309 doc version selector Docs Arrow version selector Mar 13, 2019
@pakoito
Copy link
Member

pakoito commented Mar 13, 2019

If it's all green I'm happy for it to be sent for review and stamp it!

Copy link
Member

@calvellido calvellido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sidebar dropdown button doesn't fill the sidebar width completely, which creates a weird effect when the rest of elements in the sidebar do.

@israelperezglez what's your take on this?

@raulraja
Copy link
Member

@calvellido @AntonioMateoGomez merge at will when this is ready to go

Copy link
Member

@calvellido calvellido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@calvellido calvellido marked this pull request as ready for review March 16, 2019 15:57
@calvellido calvellido merged commit b686936 into master Mar 16, 2019
@calvellido calvellido deleted the paolo-arrow-1309-doc-version-selector branch March 16, 2019 16:45
@raulraja raulraja mentioned this pull request Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs version selector

5 participants