Merged
Conversation
The passed matcher function of the should function currently only
creates a Result object, but does not do anything with it. To make a
unit test actually fail, a Matcher object should be passed to the
overloaded should function. This commit is changing this behaviour of
the shouldBeEq function.
After applying this fix, the kotlintest test
"shouldBeEq improved" {
1.shouldBeEq(2, Int.eq())
}
will fail with the following error message:
Expected: 2 but found: 1
java.lang.AssertionError: Expected: 6 but found: 5
at arrow.test.laws.LawKt.shouldBeEqAllNew(Law.kt:31)
...
Contributor
Author
|
Hey @nomisRev, it would be nice if you could take a look at this PR, since you are the original author of |
Member
|
@juliankotrba nice catch thanks! 👍 |
nomisRev
approved these changes
Mar 20, 2019
Contributor
Author
Thanks for taking your time 🙌 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The passed matcher function of the should function currently only
creates a Result object, but does not do anything with it. To make a
unit test actually fail, a Matcher object should be passed to the
overloaded should function. This commit is changing this behaviour of
the shouldBeEq function.
After applying this fix, the kotlintest test
will fail with the following error message: