ensure NonEmptyList properties are immutable#1418
Merged
pakoito merged 1 commit intoarrow-kt:masterfrom Apr 23, 2019
Merged
Conversation
Fixes arrow-kt#1312 Call toList() on List constructor arguments to ensure that the new object is unaffected by any mutations on its inputs. Without this, a mutable list can be stored as either the `all` or `tail` property of the NonEmptyList, which is affected by all changes, but is then out of sync with the other properties.
pakoito
approved these changes
Apr 23, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1312
Call toList() on List constructor arguments to ensure that the new
object is unaffected by any mutations on its inputs.
Without this, a mutable list can be stored as either the
allortailproperty of the NonEmptyList, which is affected by all changes, but is
then out of sync with the other properties.