making iterateRight an extension of Iterator #1430
making iterateRight an extension of Iterator #1430plastic-karma wants to merge 0 commit intoarrow-kt:masterfrom
Conversation
| } | ||
| } | ||
|
|
||
| fun <A, B> Iterator<A>.iterateRight(lb: Eval<B>): (f: (A, Eval<B>) -> Eval<B>) -> Eval<B> = |
There was a problem hiding this comment.
Almost there! This function returns another function, which isn't necessary in Kotlin. Make f a second parameter instead.
|
For the build to pass you'll also need to fix: |
Great, I'll fix it. Is there a gradle command I could have run to have caught this before pushing ? |
|
|
||
| @Deprecated(DeprecatedAmbiguity, ReplaceWith("raiseError(e)")) | ||
| fun raise(e: Throwable): Try<Nothing> = Failure(e) | ||
|
|
There was a problem hiding this comment.
These looks like a merge error to me! 😱
There was a problem hiding this comment.
Yeah, I tried to rebase the branch to the latest version from the upstream fork
Yep, there's the build where you can check the tasks run. In this case, https://travis-ci.org/arrow-kt/arrow/jobs/526942020#L5284-L5286 |
|
I created a new request (after messing up the branch): #1434 |
2 participants
Fix #1428.