This repository was archived by the owner on Dec 26, 2023. It is now read-only.
Fix recursive filename after several rebuilds in development#50
Merged
arthurbergmz merged 1 commit intoarthurbergmz:masterfrom Feb 13, 2018
Merged
Fix recursive filename after several rebuilds in development#50arthurbergmz merged 1 commit intoarthurbergmz:masterfrom
arthurbergmz merged 1 commit intoarthurbergmz:masterfrom
Conversation
Contributor
Author
|
@arthurbergmz Actually there's a bug which was reported in #30 that it's still unresolved when This fixes the issue. Basically, the problem is that |
Contributor
Author
|
Do not merge yet, looking at the tests. |
satazor
force-pushed
the
patch-1
branch
2 times, most recently
from
55337f9 to
d0b5d39
Compare
Contributor
Author
|
Tests are now passing! |
Also: - Fix svg assets not having the correct public url - Remove debug console.logs from the code Fixes arthurbergmz#30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the manifest url was being continuously being prefixed with the public url after each compilation, e.g.:
/build/build/build/app-manifest/manifest.jsonAlso:
Fixes #30