fix: add utility functions to get module type#3405
Closed
jonasclaes wants to merge 1 commit intoartilleryio:mainfrom
Closed
fix: add utility functions to get module type#3405jonasclaes wants to merge 1 commit intoartilleryio:mainfrom
jonasclaes wants to merge 1 commit intoartilleryio:mainfrom
Conversation
This PR will add more complete handling with regards to the CommonJS and ESM standards. This PR should solve artilleryio#3203 and artilleryio#2661. We now look at the extension first, if it's .cjs or .mjs, great, that's easy to resolve. Otherwise, we look for the first package.json we come across, check it's module type, and then determine the project's standards. The esbuild has been updated to accomodate this change as well.
|
|
Member
|
thank you @jonasclaes! will aim to review & release in the next version of Artillery |
Author
|
Hey @hassy! It's been almost two months since the opening of this PR now. Do you have an estimate of when this next version will be released including this change? Thanks in advance! |
Author
|
Closed due to non-response. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR will add more complete handling with regards to the CommonJS and ESM standards. This PR should solve #3203 and #2661.
We now look at the extension first, if it's .cjs or .mjs, great, that's easy to resolve. Otherwise, we look for the first package.json we come across, check it's module type, and then determine the project's standards.
The esbuild has been updated to accomodate this change as well.
Pre-merge checklist
This is for use by the Artillery team. Please leave this in if you're contributing to Artillery.