fix: optional task role name in Fargate run command#3469
Merged
hassy merged 3 commits intoartilleryio:mainfrom Feb 6, 2025
Merged
fix: optional task role name in Fargate run command#3469hassy merged 3 commits intoartilleryio:mainfrom
hassy merged 3 commits intoartilleryio:mainfrom
Conversation
Allow specifying a custom task role name when running Artillery on Fargate, with a fallback to the default worker role. This provides more flexibility in IAM role configuration during Fargate test runs.
|
|
aryasaatvik
force-pushed
the
fargate-role-name
branch
from
3d3d5e2 to
5b9d613
Compare
Update IAM resource creation to pass task role name as a parameter, removing the hardcoded constant and improving flexibility in role management.
Member
|
thanks @aryasaatvik, kicking off e2e tests on AWS Fargate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolved #3470
Allow specifying a custom task role name when running Artillery on Fargate, with a fallback to the default worker role. This provides more flexibility in IAM role configuration during Fargate test runs.
Description
currently there isn't a way to pass a custom role name for tasks to assume. In
PlatformECS.initit always looks for the default role name. this fixes it by passing thetask-role-nameflag to PlatformECSPre-merge checklist
This is for use by the Artillery team. Please leave this in if you're contributing to Artillery.