Conversation
manfromanotherland
force-pushed
the
ed-art-2084-slack-plugin-not-reporting-duration-and-status-correctly
branch
from
e4ffc59 to
b102bdd
Compare
hassy
reviewed
Jun 11, 2025
- Use `formatDuration()` function from `packages/artillery/lib/utils.js` for consistency - Check if `lastMetricAt` and `firstMetricAt` are defined before calculating duration - Only report duration if the value is valid
- Add `0` fallback for exit code in cases where is not set - Use `??` instead of `||` to prevent issues where `0 || 1` would result in `1` even when `suggestedExitCode` was explicit set to `0`
manfromanotherland
force-pushed
the
ed-art-2084-slack-plugin-not-reporting-duration-and-status-correctly
branch
from
b102bdd to
8dfb882
Compare
hassy
deleted the
ed-art-2084-slack-plugin-not-reporting-duration-and-status-correctly
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
formatDuration()function frompackages/artillery/lib/utils.jsfor consistencylastMetricAtandfirstMetricAtare defined before calculating durationPre-merge checklist
This is for use by the Artillery team. Please leave this in if you're contributing to Artillery.