fix: use correct cliOptions key for scenarioName in Fargate workers#3669
Merged
hassy merged 1 commit intoartilleryio:mainfrom Jan 21, 2026
Merged
fix: use correct cliOptions key for scenarioName in Fargate workers#3669hassy merged 1 commit intoartilleryio:mainfrom
hassy merged 1 commit intoartilleryio:mainfrom
Conversation
The condition checked `cliOptions['scenarioName']` (camelCase) but the value was read from `cliOptions['scenario-name']` (kebab-case), resulting in `null` being passed to workers. Fixes artilleryio#3589
Member
|
thanks @barth12! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
--scenario-nameflag was not being passed correctly to Fargate workers, causing them to receivenullinstead of the actual scenario name.Root Cause
In
generateTaskOverrides(), the condition checkedcliOptions['scenarioName'](camelCase) but the value was read fromcliOptions['scenario-name'](kebab-case):Fix
Use the correct camelCase key consistently:
Related
Fixes #3589 - this appears to be a regression or incomplete fix from #3651