feat: add CLI heartbeat mechanism on Fargate#3705
Merged
Conversation
Add startedBy (context.testId) to ECS RunTask params to enable ListTasks queries by test ID. Add e2e test that spawns a long-running Fargate test, SIGKILLs the CLI, then polls ECS to verify workers detect the missing heartbeat and self-terminate within the expected window (180-300s). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CLI: write heartbeat to single key (heartbeat.json) with timestamp as body instead of creating unique files under heartbeat/ prefix. Avoids s3api list-objects-v2 + JMESPath on worker side. Worker: replace s3api list-objects-v2 with aws s3 cp (proven pattern used by go signal, log upload). Failures now visible via printf instead of debug(). Add SIGTERM → 15s wait → SIGKILL escalation matching the existing cleanup() pattern, since Artillery catches SIGTERM for graceful shutdown and may not exit promptly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix for scenarios where the CLI is either SIGKILL'ed or where graceful shutdown does not terminate Fargate tasks correctly.
Pre-merge checklist
This is for use by the Artillery team. Please leave this in if you're contributing to Artillery.