fix(order2): QA minor design fixes#16594
Conversation
| > | ||
| Save bank account for later use. | ||
| </Checkbox> | ||
| <Flex p={2} position="relative"> |
There was a problem hiding this comment.
This prevents the tooltip from causing whitespace at the end of the page
| <Order2ExpressCheckout order={orderData} /> | ||
| )} | ||
| {isOffer && ( | ||
| <> |
There was a problem hiding this comment.
gap={1} was adding space to these empty fragments, causing the layout spacing issues, so changed them to box
oxaudo
left a comment
oxaudo
left a comment
There was a problem hiding this comment.
The changes look good to me.
One question on saved payments. The spacing in a screenshot looks a bit awkward to me - was not sure what that is. Comparing to the design realizing the whole content of the dropdown seem to have left margin in the design:
Is that not something we can configure on Stripe?
|
@oxaudo if we keep the left margin like the screenshot it would have to align with "Saved payments" but "Saved payments" needs to be the same margin as the Stripe elements to match, but it's not able to be changed on Stripe's side. |
#5939 Bundle Size — 9.53MiB (~-0.01%).7e7881e(current) vs d66bf53 main#5937(baseline) Warning Bundle contains 34 duplicate packages – View duplicate packages Bundle metrics
|
| Current #5939 |
Baseline #5937 |
|
|---|---|---|
 Initial JS |
3.71MiB(~-0.01%) |
3.71MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
43.31% |
37.5% |
| Chunks |
99 |
99 |
| Assets |
102 |
102 |
| Modules |
5974 |
5974 |
| Duplicate Modules |
613 |
613 |
| Duplicate Code |
4.05% |
4.05% |
| Packages |
297 |
297 |
| Duplicate Packages |
33 |
33 |
Bundle size by type 1 change 1 improvement
| Current #5939 |
Baseline #5937 |
|
|---|---|---|
| JS |
9.39MiB (~-0.01%) |
9.39MiB |
| Other |
143.59KiB |
143.59KiB |
Bundle analysis report Branch rquartararo/order2-minor-design-... Project dashboard
Generated by RelativeCI Documentation Report issue
| switch (paymentMethod) { | ||
| case "CREDIT_CARD": { | ||
| if (paymentPreview && paymentPreview.__typename === "Card") { | ||
| const cardBrand = paymentPreview.displayBrand |
There was a problem hiding this comment.
This fixes the payment preview (payment details in the context) card brand display as the string does not match what is needed for BrandCreditCardIcon component. We can remove this once we remove payment details from the context.
2 participants
The type of this PR is: Fix
This PR solves EMI-3027
Description
This PR fixes:
New saved payment options desgin
Payment element inputs