Enforce per-method lodash imports to reduce bundle size#16829
Draft
MounirDhahri wants to merge 9 commits intomainfrom
Draft
Enforce per-method lodash imports to reduce bundle size#16829MounirDhahri wants to merge 9 commits intomainfrom
MounirDhahri wants to merge 9 commits intomainfrom
Conversation
Import individual lodash methods (e.g., `import compact from "lodash/compact"`) across ~170 files instead of importing the entire library, reducing bundle size by tree-shaking unused methods. Also adds a `yarn check:lodash` script and documents the rule in AGENTS.md to prevent regressions. Co-authored-by: claude-sonnet-4-6 <claude-sonnet-4-6@anthropic.com> https://claude.ai/code/session_01EHt5dM7Rts48s8HzcCaZCz
|
Hi there! 👋 |
Co-authored-by: claude-sonnet-4-6 <claude-sonnet-4-6@anthropic.com> https://claude.ai/code/session_01EHt5dM7Rts48s8HzcCaZCz
MounirDhahri
commented
Feb 19, 2026
AGENTS.md
Outdated
| - Prefer named exports; avoid default exports | ||
| - Prefer explicit returns; avoid implicit returns | ||
| - Force follows conventional typographical style and prefers curly typographic single quotes(`‘` and `’`) and double quotes (`“` and `”`) in user-facing texts. Consider this when generating or updating code, including tests | ||
| - Force follows conventional typographical style and prefers curly typographic single quotes(`'` and `'`) and double quotes (`"` and `"`) in user-facing texts. Consider this when generating or updating code, including tests |
#6858 Bundle Size — 8.62MiB (-0.38%).d9fcf07(current) vs e4a3991 main#6855(baseline) Warning Bundle contains 31 duplicate packages – View duplicate packages Bundle metrics
|
| Current #6858 |
Baseline #6855 |
|
|---|---|---|
 Initial JS |
2.78MiB(-2.1%) |
2.84MiB |
 Initial CSS |
0B |
0B |
 Cache Invalidation |
84.79% |
19.52% |
| Chunks |
111(+0.91%) |
110 |
| Assets |
114(+0.88%) |
113 |
| Modules |
5694(+3.28%) |
5513 |
 Duplicate Modules |
664(+7.79%) |
616 |
| Duplicate Code |
5.24%(+6.5%) |
4.92% |
| Packages |
250 |
250 |
| Duplicate Packages |
30 |
30 |
Bundle size by type 2 changes 1 regression 1 improvement
| Current #6858 |
Baseline #6855 |
|
|---|---|---|
| JS |
8.46MiB (-0.41%) |
8.5MiB |
| Other |
154.94KiB (+1.45%) |
152.73KiB |
Bundle analysis report Branch claude/fix-lodash-imports-wvjbx Project dashboard
Generated by RelativeCI Documentation Report issue
…c line
The throttle mock targeted "lodash" but the source now imports from
"lodash/throttle", so jest.mock("lodash/throttle", ...) is needed.
Co-authored-by: claude-sonnet-4-6 <claude-sonnet-4-6@anthropic.com>
https://claude.ai/code/session_01EHt5dM7Rts48s8HzcCaZCz
Upgrade Biome from 1.9.4 to 2.4.2 to enable the noRestrictedImports
lint rule, which bans whole-library lodash imports (e.g.
`import { debounce } from "lodash"`) while allowing per-method deep
imports (e.g. `import debounce from "lodash/debounce"`).
New v2 rules that would flag pre-existing code are disabled to keep
this upgrade non-breaking. These can be enabled incrementally.
Co-authored-by: Claude <noreply@anthropic.com>
https://claude.ai/code/session_01EHt5dM7Rts48s8HzcCaZCz
Member
Author
|
I am waiting for my claude limit to be over then for claude to remove |
anandaroop
reviewed
Feb 19, 2026
| - Write correctly typed code; avoid adding `@ts-expect-error` | ||
| - Prefer named exports; avoid default exports | ||
| - Prefer explicit returns; avoid implicit returns | ||
| - Force follows conventional typographical style and prefers curly typographic single quotes(`‘` and `’`) and double quotes (`“` and `”`) in user-facing texts. Consider this when generating or updating code, including tests |
Member
There was a problem hiding this comment.
Hmm, Claude didn't just revert the change as asked — but is actually trying to delete this now?
Member
There was a problem hiding this comment.
Are all the new rules in this file already passing? Wondering how to make sense of these additions.
Member
Author
There was a problem hiding this comment.
i guess claude thought they are required after the upgrade to latest biome - I will rever them and see
Member
Author
There was a problem hiding this comment.
aha - it has a point
Member
There was a problem hiding this comment.
Ah I see, they were all set to "off" thus effectively disabled. Makes sense.
…s types Now that Biome v2 has been upgraded and several rules disabled globally, the corresponding biome-ignore suppression comments are unused and cause lint errors. Remove them all. Also fix type errors in countChangedFilters.ts introduced by the switch from named to per-method lodash imports, which changed the type signature of `transform`. Co-authored-by: Claude <noreply@anthropic.com> https://claude.ai/code/session_01EHt5dM7Rts48s8HzcCaZCz
MounirDhahri
force-pushed
the
claude/fix-lodash-imports-wvjbx
branch
from
31e1326 to
5fb7f1f
Compare
Co-authored-by: Claude <noreply@anthropic.com> https://claude.ai/code/session_01EHt5dM7Rts48s8HzcCaZCz
The curly typographic quotes were mangled during a previous restore. Reset from main to ensure no unintended changes. Co-authored-by: Claude <noreply@anthropic.com> https://claude.ai/code/session_01EHt5dM7Rts48s8HzcCaZCz
anandaroop
previously approved these changes
Feb 20, 2026
Enable the biome correctness/useExhaustiveDependencies lint rule (was previously "off"). All existing violations are suppressed with biome-ignore comments added via `biome lint --suppress`. Co-authored-by: Claude <noreply@anthropic.com> https://claude.ai/code/session_01EHt5dM7Rts48s8HzcCaZCz
…ents Re-enable rules that were disabled in the Biome v2 upgrade but had existing biome-ignore suppressions on main: - correctness/useExhaustiveDependencies (warn) - correctness/useHookAtTopLevel (warn) - suspicious/noAssignInExpressions (warn) - suspicious/noThenProperty (warn) - a11y/useKeyWithClickEvents (warn) - a11y/useValidAnchor (warn) Restore original biome-ignore comments (with their original reasons rather than the generic "ignored using --suppress" text). Add biome-ignore suppression for new violations introduced by the Biome v2.4.2 upgrade detecting additional cases. Co-authored-by: Claude <noreply@anthropic.com> https://claude.ai/code/session_01EHt5dM7Rts48s8HzcCaZCz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The type of this PR is: Refactor
Description
Migrates lodash imports from whole-library style (import { compact } from "lodash") to per-method style (import compact from "lodash/compact") across the codebase, enabling tree-shaking of unused lodash utilities.
https://claude.ai/code/session_01EHt5dM7Rts48s8HzcCaZCz